This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add method/format information to =record-started
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Mon, 6 Jun 2016 09:39:50 -0400
- Subject: Re: [PATCH] Add method/format information to =record-started
- Authentication-results: sourceware.org; auth=none
- References: <20160603155220 dot 22286-1-simon dot marchi at ericsson dot com> <A78C989F6D9628469189715575E55B23332EAEF5 at IRSMSX104 dot ger dot corp dot intel dot com> <57557571 dot 7040200 at ericsson dot com> <A78C989F6D9628469189715575E55B23332EB299 at IRSMSX104 dot ger dot corp dot intel dot com>
On 16-06-06 09:20 AM, Metzger, Markus T wrote:
> Looks good except that BTRACE_FORMAT_NONE is not handled in the switch.
>
> We could leave it as a bad format string to be detected by the MI consumer. This would
> leave the short and long versions of btrace_format_string symmetric.
What do you mean by MI consumer? The MI front-end (e.g. Eclipse), or the MI interpreter
code in gdb (mi-interp.c) ?
My thought was that not handling it in the switch (and let gdb implode) would help catch
a bug earlier, compared to emitting some invalid string. But I don't really mind. I can
add
case BTRACE_FORMAT_NONE:
return "unknown";