This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 3/4] Add variable length tests for emit_ref in trace-condition.exp
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 27 May 2016 09:04:13 -0400
- Subject: Re: [PATCH 3/4] Add variable length tests for emit_ref in trace-condition.exp
- Authentication-results: sourceware.org; auth=none
- References: <1463504594-4419-1-git-send-email-antoine dot tremblay at ericsson dot com> <1463504594-4419-3-git-send-email-antoine dot tremblay at ericsson dot com> <f405088b-5621-234b-5080-400c92de2f66 at redhat dot com>
Pedro Alves writes:
> On 05/17/2016 06:03 PM, Antoine Tremblay wrote:
>> This patch add variable length tests for emit_ref by reading the variable
>> passed as argument of 8 to 64 bit.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.trace/trace-condition.c (marker): Adapt signature to 8 to 64
>> bits types.
>> (main): Adapt to 8 to 64 bits types.
>> * gdb.trace/trace-condition.exp: Add new tests.
>
> Looks OK to me, but same comment as previous patches.
Note that I don't think the same comment applies here as tests check for
1 or 2 frames only. So you could not get an unconditional error.
test_tracepoints $trace_command "arg8 == 1 || arg8 == 2" 2
For example will test 2 values and collect 2 frames max to pass.
Thanks,
Antoine