This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [PR symtab/19999] Fix
- From: Doug Evans <dje at google dot com>
- To: Yunlian Jiang <yunlian at google dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Sriraman Tallam <tmsriram at google dot com>
- Date: Thu, 12 May 2016 09:26:50 -0700
- Subject: Re: [PATCH] [PR symtab/19999] Fix
- Authentication-results: sourceware.org; auth=none
- References: <14dae93406d1e6a96b0531a2ceec at google dot com> <CAMsPy2uLjo4TMF0veVpWG90m337p7G6-wLYX99ERnmcNc6+gog at mail dot gmail dot com>
On Wed, May 11, 2016 at 9:22 AM, Yunlian Jiang <yunlian@google.com> wrote:
> ping?
For reference sake, some people here get violently ill with top-posting.
Me, I just go with the flow for each message and don't really care.
But heads up.
> On Fri, Apr 29, 2016 at 10:16 AM, Doug Evans <dje@google.com> wrote:
>> Hi.
>>
>> This patch fixes symtab/19999.
>> The problem here is that while we don't want to add the DWARF "base address"
>> for DWO files (where addresses come from .debug_addr where the base address
>> has already been added), we still need to add base_offset for PIE.
>>
>> Regression tested on amd64-linux.
>>
>> 2016-04-29 Doug Evans <dje@google.com>
>>
>> PR symtab/19999
>> * dwarf2loc.c (dwarf2_find_location_expression): For DWO files still
>> add base_offset.
>>
>> testsuite/
>> * lib/dwarf.exp (build_executable_from_fission_assembler): Pass
>> $options when building executable.
>> * gdb.dwarf2/fission-loclists-pie.S: New file.
>> * gdb.dwarf2/fission-loclists-pie.exp: New file.
Committed.