This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][gdb] Fix -Wparentheses warnings
- From: Pedro Alves <palves at redhat dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at foss dot arm dot com>, gdb-patches at sourceware dot org
- Date: Tue, 3 May 2016 11:02:49 +0100
- Subject: Re: [PATCH][gdb] Fix -Wparentheses warnings
- Authentication-results: sourceware.org; auth=none
- References: <57237D3A dot 2050203 at foss dot arm dot com> <55918437-8fb0-3d99-645a-667339829bc8 at redhat dot com> <5bafc0fe-a620-ab2b-82c6-4ba77fd9a7eb at redhat dot com> <572868DF dot 4080800 at foss dot arm dot com>
On 05/03/2016 10:01 AM, Kyrill Tkachov wrote:
> On 02/05/16 18:03, Pedro Alves wrote:
>> On 05/02/2016 11:57 AM, Pedro Alves wrote:
>>> On 04/29/2016 04:26 PM, Kyrill Tkachov wrote:
>>> Bah. That's written that way exactly to avoid dangling if/else
>>> problems.
>>>
>>> I think it'd be reasonable for gcc to not warn when the if/else
>>> came from a macro, as users of the macro can't possibly be confused
>>> in the way the warning intents to help with. I'd call it a
>>> gcc regression.
>>>
>
> I see what you mean.
> I filed GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70922
> to get the GCC devs opinion.
Thanks. I added some more info there.
>> I suspect this may be the same as PR20029:
>>
>> https://sourceware.org/bugzilla/show_bug.cgi?id=20029
>>
>> Could you push it to the gdb-7.11-branch branch too, please?
>
> I've pushed the patch to master and gdb-7.11-branch.
Great, thanks again.
> I've not used the sourceware bugzilla before (I don't have an account
> there AFAIK),
> so if someone could confirm that the warnings are fixed and close that
> accordingly
> I'd appreciate it.
I'll take it from here.
--
Pedro Alves