This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH 2/2] Fix solib-display.exp remote check
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Date: Mon, 2 May 2016 14:18:00 -0400
- Subject: [PATCH 2/2] Fix solib-display.exp remote check
- Authentication-results: sourceware.org; auth=none
- References: <1462213080-22823-1-git-send-email-simon dot marchi at ericsson dot com>
From: Simon Marchi <simon dot marchi at polymtl dot ca>
This test currently uses [is_remote target] to check if the test is
supported. This is not quite correct, as the limitation is actually
that it requires support for "running", ruling out stub-like targets.
Therefore, it should check for use_gdb_stub.
This has no visible effect right now, but it will once we make the
native-gdbserver board non-dejagnu-remote.
gdb/testsuite/ChangeLog:
* gdb.base/solib-display.exp: Check for [use_gdb_stub]Âinstead
of [is_remote target],
---
gdb/testsuite/gdb.base/solib-display.exp | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb.base/solib-display.exp
index 7f65617..e8ab330 100644
--- a/gdb/testsuite/gdb.base/solib-display.exp
+++ b/gdb/testsuite/gdb.base/solib-display.exp
@@ -28,7 +28,13 @@
# (and thus aren't affected by shared library unloading) are not
# disabled prematurely.
-if { [skip_shlib_tests] || [is_remote target] } {
+if { [skip_shlib_tests] } {
+ return 0
+}
+
+# This test currently requires "run", so it's pointless to test on stub targets.
+
+if { [use_gdb_stub] } {
return 0
}
--
2.8.2