This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- From: Martin Galvan <martin dot galvan at tallertechnologies dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: gdb-patches <gdb-patches at sourceware dot org>, Tom Tromey <tom at tromey dot com>, Daniel Gutson <daniel dot gutson at tallertechnologies dot com>
- Date: Wed, 27 Apr 2016 12:10:07 -0300
- Subject: Re: [PATCH] c_value_print: Revert 'val' to a reference for TYPE_CODE_STRUCT
- Authentication-results: sourceware.org; auth=none
- References: <1461707298-26514-1-git-send-email-martin dot galvan at tallertechnologies dot com> <57208DFF dot 3020801 at redhat dot com> <CAOKbPbY_NuRyB_HJsLHLJjXT_UsSWFJxwuVpdxxUnLFxkBvSLQ at mail dot gmail dot com> <5720C0F6 dot 9060806 at redhat dot com>
On Wed, Apr 27, 2016 at 10:39 AM, Pedro Alves <palves@redhat.com> wrote:
> It's better to be explicit in such cases, and say something like,
> "this has no effect currently, so can be seen as a small code
> cleanup, but once we do X, we'll print the wrong thing", or some such,
> and mention that this causes no testsuite regressions, in the
> email/commit log.
Indeed, you're right. I mentioned it in the commit log. Here's what I committed:
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git&a=commit&h=476350ba4800f1144b125f6511a5e25b223cc90b
Thanks!