This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 2/2] Make breakpoint handling in record-full idempotent

From: Luis Machado <lgustavo at codesourcery dot com>
To: Yao Qi <qiyaoltc at gmail dot com>
Cc: <gdb-patches at sourceware dot org>
Date: Wed, 6 Apr 2016 07:20:38 -0500
Subject: Re: [PATCH 2/2] Make breakpoint handling in record-full idempotent
Authentication-results: sourceware.org; auth=none
References: <1459759138-1494-1-git-send-email-yao dot qi at linaro dot org> <1459759138-1494-3-git-send-email-yao dot qi at linaro dot org> <570426E4 dot 8090901 at codesourcery dot com> <86shyzm889 dot fsf at gmail dot com>
Reply-to: Luis Machado <lgustavo at codesourcery dot com>

On 04/06/2016 03:50 AM, Yao Qi wrote:

Luis Machado <lgustavo@codesourcery.com> writes:

Hi Luis,

+  /* Find any existing entries.  */


Should this say...

/* Make sure there are no duplicate breakpoint entries.  */

... instead?


I put tow comments together,

     /* Use the existing entries if found in order to avoid duplication
        in record_full_breakpoints.  */


Thanks. That reads better.

References:
- [PATCH 0/2] Make breakpoint handling in record-full idempotent
  - From: Yao Qi
- [PATCH 2/2] Make breakpoint handling in record-full idempotent
  - From: Yao Qi
- Re: [PATCH 2/2] Make breakpoint handling in record-full idempotent
  - From: Luis Machado
- Re: [PATCH 2/2] Make breakpoint handling in record-full idempotent
  - From: Yao Qi

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]