This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: Commit: AArch64: Simulate scalar NEG and vector MUL
- From: Nick Clifton <nickc at redhat dot com>
- To: gdb-patches at sourceware dot org
- Date: Fri, 18 Mar 2016 14:26:35 +0000
- Subject: Re: Commit: AArch64: Simulate scalar NEG and vector MUL
- Authentication-results: sourceware.org; auth=none
- References: <87io0kt9lt dot fsf at redhat dot com> <20160318132718 dot GF6588 at vapier dot lan>
Hi Mike,
>> +#define GET_VEC_ELEMENT(REG, ELEMENT, FIELD) \
> is using all caps for arg names a normal style thing ?
For macros, yes.
For example, in gdb/gdbarch.h:
#define GDBARCH_OBSTACK_CALLOC(GDBARCH, NR, TYPE) ((TYPE *) gdbarch_obstack_zalloc ((GDBARCH), (NR) * sizeof (TYPE)))
>> + if (element > ARRAY_SIZE (cpu->fr[0].FIELD)) \
> shouldn't this be ELEMENT ? and be >= ?
Yes.
>> + if (ELEMENT > ARRAY_SIZE (cpu->fr[0].FIELD)) \
Yup. Patch coming.
Cheers
Nick