This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [spu] throw error when target_read_memory fails


Yao Qi wrote:

> I happen to see that 1 is returned in spu_software_single_step when
> target_read_memory returns 1.  It must be wrong.  That patch changes
> it to throwing an error.  Note that I choose to throw error because I
> find the code in the end of spu_software_single_step throws errors.

It probably doesn't matter much, since reading SPU local store
cannot really fail, but I guess it can't hurt to handle errors
properly anyway ...

> 2016-03-17  Yao Qi  <yao.qi@linaro.org>
> 
> 	* spu-tdep.c (spu_software_single_step): Throw error when
> 	target_read_memory fails.

This is OK.

Thanks,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU/Linux compilers and toolchain
  Ulrich.Weigand@de.ibm.com


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]