This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] [spu] throw error when target_read_memory fails
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: qiyaoltc at gmail dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 Mar 2016 08:37:17 +0100 (CET)
- Subject: Re: [PATCH] [spu] throw error when target_read_memory fails
- Authentication-results: sourceware.org; auth=none
Yao Qi wrote:
> I happen to see that 1 is returned in spu_software_single_step when
> target_read_memory returns 1. It must be wrong. That patch changes
> it to throwing an error. Note that I choose to throw error because I
> find the code in the end of spu_software_single_step throws errors.
It probably doesn't matter much, since reading SPU local store
cannot really fail, but I guess it can't hurt to handle errors
properly anyway ...
> 2016-03-17 Yao Qi <yao.qi@linaro.org>
>
> * spu-tdep.c (spu_software_single_step): Throw error when
> target_read_memory fails.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU/Linux compilers and toolchain
Ulrich.Weigand@de.ibm.com