This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type
- From: Keith Seitz <keiths at redhat dot com>
- To: Artemiy Volkov <artemiyv at acm dot org>, gdb-patches at sourceware dot org
- Date: Wed, 16 Mar 2016 15:07:56 -0700
- Subject: Re: [PATCH v3 01/11] [PR gdb/14441] gdb: gdbtypes: add definitions for rvalue reference type
- Authentication-results: sourceware.org; auth=none
- References: <1453229609-20159-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-1-git-send-email-artemiyv at acm dot org> <1457147955-21871-2-git-send-email-artemiyv at acm dot org>
On 03/04/2016 07:19 PM, Artemiy Volkov wrote:
> diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h
> index e775a1d..3bdbcd9 100644
> --- a/gdb/gdbtypes.h
> +++ b/gdb/gdbtypes.h
> @@ -362,6 +364,11 @@ enum type_instance_flag_value
> #define TYPE_ATOMIC(t) \
> (TYPE_INSTANCE_FLAGS (t) & TYPE_INSTANCE_FLAG_ATOMIC)
>
> +/* True if this type represents either an lvalue or lvalue reference type. */
> +
I think there's a missing '*' docbook marker on this comment. [Arguably,
that whole thing appears to have fallen by the wayside...]
> +#define TYPE_IS_REFERENCE(t) \
> + (TYPE_CODE (t) == TYPE_CODE_REF || TYPE_CODE (t) == TYPE_CODE_RVALUE_REF)
> +
> /* * Instruction-space delimited type. This is for Harvard architectures
> which have separate instruction and data address spaces (and perhaps
> others).
Otherwise looks good.
Keith