This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[PATCH] feature_to_c.sh: Print help when passing no arguments
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: <gdb-patches at sourceware dot org>
- Cc: Simon Marchi <simon dot marchi at ericsson dot com>
- Date: Mon, 29 Feb 2016 13:30:06 -0500
- Subject: [PATCH] feature_to_c.sh: Print help when passing no arguments
- Authentication-results: sourceware.org; auth=none
I found that odd that passing no arguments to feature_to_c.sh produces
this:
$ ./feature_to_c.sh
./feature_to_c.sh: 23: shift: can't shift that many
but passing one argument shows the help:
$ ./feature_to_c.sh hello
Usage: ./feature_to_c.sh OUTPUTFILE INPUTFILE...
This patch changes the script to show the help in both cases.
gdb/ChangeLog:
* features/feature_to_c.sh: Print the help when passing no
argument.
---
gdb/features/feature_to_c.sh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/features/feature_to_c.sh b/gdb/features/feature_to_c.sh
index 901eb0d..439611a 100755
--- a/gdb/features/feature_to_c.sh
+++ b/gdb/features/feature_to_c.sh
@@ -19,14 +19,14 @@
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
-output=$1
-shift
-
-if test -z "$output" || test -z "$1"; then
+if test -z "$1" || test -z "$2"; then
echo "Usage: $0 OUTPUTFILE INPUTFILE..."
exit 1
fi
+output=$1
+shift
+
if test -e "$output"; then
echo "Output file \"$output\" already exists; refusing to overwrite."
exit 1
--
2.5.1