This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 1/4] Teach arm unwinders to terminate gracefully
- From: Yao Qi <qiyaoltc at gmail dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, Pedro Alves <palves at redhat dot com>, <gdb-patches at sourceware dot org>
- Date: Fri, 26 Feb 2016 09:12:03 +0000
- Subject: Re: [PATCH 1/4] Teach arm unwinders to terminate gracefully
- Authentication-results: sourceware.org; auth=none
- References: <1452188697-23870-1-git-send-email-antoine dot tremblay at ericsson dot com> <1452188697-23870-2-git-send-email-antoine dot tremblay at ericsson dot com> <86io1ung0a dot fsf at gmail dot com> <56CEE928 dot 2080704 at redhat dot com> <wwokbn757wyi dot fsf at ericsson dot com>
Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
> Reading Pedro's description I'm not against the refactoring but it's non
> trivial to me at the moment at least.
It is not a simple refacotring...
>
> I suggest we allow this patch to go in in order to make progress on the
> arm tracepoint patchset and do that refactoring in a subsequent patch.
>
> Would that be OK ?
I am afraid not. We should try this approach, because this will benefit
all targets. IMO, handling unavailable memory in general frame
unwinding is more important.
b.t.w, I am still not confident on the arm software single step in
GDBserver on some cases, such as branch-to-self (".L2: b .L2") and
single step with signal. ARM tracepoint patches can go in after these
issues are resolved (I am working on these issues).
--
Yao (éå)