This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.

From: Marcin KoÅcielnicki <koriakin at 0x04 dot net>
To: Ulrich Weigand <uweigand at de dot ibm dot com>
Cc: lgustavo at codesourcery dot com, arnez at linux dot vnet dot ibm dot com, gdb-patches at sourceware dot org
Date: Thu, 18 Feb 2016 16:41:42 +0100
Subject: Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
Authentication-results: sourceware.org; auth=none
References: <20160218154028 dot 870066B9A at oc7340732750 dot ibm dot com>

On 18/02/16 16:40, Ulrich Weigand wrote:

Marcin KoÅ›cielnicki wrote:

	* gdbarch.c: Regenerate.
	* gdbarch.h: Regenerate.
	* gdbarch.sh: Add guess_tracepoint_registers hook, include
	tracepoint.h.
	* tracefile.c (tracefile_fetch_registers): Use the new gdbarch hook.
	* tracepoint.c (default_guess_tracepoint_registers): New function.
	* tracepoint.h (default_guess_tracepoint_registers): New prototype.

  #include "observer.h"
  #include "regcache.h"
  #include "objfiles.h"
+#include "tracepoint.h"


I don't think you actually need this include, do you?

Otherwise, this patch is OK.

Bye,
Ulrich

I do, the default_guess_tracepoint_registers function is declared there,and gdbarch.c uses it.

Follow-Ups:
- Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
  - From: Ulrich Weigand

References:
- Re: [PATCH] gdb: Add guess_tracepoint_registers hook to gdbarch.
  - From: Ulrich Weigand

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]