This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] arm-tdep.c: Change type of insn parameters
- From: Simon Marchi <simon dot marchi at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Thu, 11 Feb 2016 13:21:58 -0500
- Subject: Re: [PATCH] arm-tdep.c: Change type of insn parameters
- Authentication-results: sourceware.org; auth=none
- References: <1455146137-30672-1-git-send-email-simon dot marchi at ericsson dot com> <86wpqbpl7m dot fsf at gmail dot com>
On 16-02-11 05:58 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> /* Copy 16-bit Thumb(Thumb and 16-bit Thumb-2) instruction without any
>> modification. */
>> static int
>> -thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, unsigned int insn,
>> +thumb_copy_unmodified_16bit (struct gdbarch *gdbarch, uint32_t insn,
>> const char *iname,
>> struct displaced_step_closure *dsc)
>
> The instruction here is 16-bit, so we should use "uint16_t".
>
> OK with the change.
>
Thanks, pushed with that changed.