This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook.
- From: Pedro Alves <palves at redhat dot com>
- To: Marcin KoÅcielnicki <koriakin at 0x04 dot net>, gdb-patches at sourceware dot org
- Date: Wed, 10 Feb 2016 13:50:40 +0000
- Subject: Re: [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook.
- Authentication-results: sourceware.org; auth=none
- References: <1454773157-31569-1-git-send-email-koriakin at 0x04 dot net> <1454792070-25410-1-git-send-email-koriakin at 0x04 dot net> <56BB3BAA dot 3050908 at redhat dot com> <56BB3C7E dot 4080102 at 0x04 dot net>
On 02/10/2016 01:34 PM, Marcin KoÅcielnicki wrote:
>> I don't understand this comment. amd64_ax_pseudo_register_collect
>> checks i386_byte_regnum_p before ever reaching here, afaics.
>
> I've copied it from i386_pseudo_register_read_into_value - didn't make
> that much sense to me either. Let's remove it from both places?
Yes please.
Thanks,
Pedro Alves