This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Introduce skip_to_char and use it
- From: Andreas Schwab <schwab at suse dot de>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Sergio Durigan Junior <sergiodj at redhat dot com>, Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Wed, 27 Jan 2016 12:53:07 +0100
- Subject: Re: [PATCH] Introduce skip_to_char and use it
- Authentication-results: sourceware.org; auth=none
- References: <1453845250-30360-1-git-send-email-simon dot marchi at ericsson dot com> <878u3b24f8 dot fsf at redhat dot com> <56A8A855 dot 8050208 at redhat dot com>
Pedro Alves <palves@redhat.com> writes:
> On 01/27/2016 01:32 AM, Sergio Durigan Junior wrote:
>
>> The problem with skip_to_char IMO is that it leads the reader to believe
>> that this function performs the same job as strchr (in fact, my first
>> reaction when I read this introduction was to think "why not use
>> strchr?"). The main difference, however, is that this function actually
>> skips everything if the char was not found.
>>
>> I believe a name like "skip_to_char_or_nul" may be more appropriate.
>> What do you think?
>
> That sounds just like strchrnul, though.
Or strcspn.
Andreas.
--
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."