This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] Add a new format letter to dump instructions backward
- From: Toshihito Kikuchi <k dot toshihito at yahoo dot de>
- To: "Paul_Koning at Dell dot com" <Paul_Koning at Dell dot com>, "palves at redhat dot com" <palves at redhat dot com>
- Cc: "jhb at freebsd dot org" <jhb at freebsd dot org>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 26 Jan 2016 05:36:58 +0000 (UTC)
- Subject: Re: [PATCH] Add a new format letter to dump instructions backward
- Authentication-results: sourceware.org; auth=none
- References: <F83BD80E-E1AA-4C1E-86BB-9A995B831256 at dell dot com>
- Reply-to: Toshihito Kikuchi <k dot toshihito at yahoo dot de>
Thank you for the great suggestion.
I also agree that #3, adding the support for a negative number, looks reasonable. I'll get back to this thread when the code is ready.
To answer the question from Paul, Pedro's guess is correct. I used symbol's line info to solve a correct frame. And yes, this feature does not work without debug information unfortunately. Since I'm not familiar with architectures other than x86, let me finish this work in the current approach first. If there are architectures where instruction length is fixed, I think I can add them later.
> Adding some tests would be great. Also, the documentation
> will need to be updated.
>
> If you haven't yet, please take a look at:
> https://sourceware.org/gdb/wiki/ContributionChecklist
Thank you for pointing to this. I looked at only gdb/CONTRIBUTE and didn't reach this. Tests and doc updates will be included in next patch.
Thanks,
Toshihito