This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: Respect CXXFLAGS when building with C++ compiler
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 21 Jan 2016 11:37:04 +0000
- Subject: Re: [PATCH] gdb: Respect CXXFLAGS when building with C++ compiler
- Authentication-results: sourceware.org; auth=none
- References: <1453288024-19890-1-git-send-email-palves at redhat dot com> <569FE883 dot 7050706 at ericsson dot com> <569FF0B2 dot 7070300 at redhat dot com> <56A00FC7 dot 7030100 at ericsson dot com>
On 01/20/2016 10:52 PM, Simon Marchi wrote:
> On 16-01-20 03:40 PM, Pedro Alves wrote:
>> Yeah, it crossed my mind too, but then all others end up _CFLAGS,
>> like INTERNAL_CFLAGS, GLOBAL_CFLAGS, GDB_WERROR_CFLAGS,
>> INTERNAL_WARN_CFLAGS, etc., which are used in c++ too,
>> that I thought it ended up looking the odd one out. WDYT?
>
> Then you can change the others too :)
>
> INTERNAL_CFLAGS -> INTERNAL_COMPILER_FLAGS
> GLOBAL_CFLAGS -> GLOBAL_COMPILER_FLAGS
> GDB_WERROR_CFLAGS -> GDB_WERROR_COMPILER_FLAGS
> etc...
>
> But it's a minor detail and probably temporary too, so I'm fine
> with COMPILER_CFLAGS.
Yeah, I'd rather not change everything. Maybe we'll rename all
those to INTERNAL_CXXFLAGS, etc. soon enough. :-)
I've pushed the patch in now.
Thanks,
Pedro Alves