This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Use a separate variable for the size passed to sysctl.


On 01/19/2016 07:35 PM, John Baldwin wrote:
> On Tuesday, January 19, 2016 07:18:49 PM Pedro Alves wrote:
>> OK with ...
>>
>> On 01/19/2016 06:24 PM, John Baldwin wrote:
>>> --- a/gdb/ChangeLog
>>> +++ b/gdb/ChangeLog
>>> @@ -1,5 +1,10 @@
>>>  2016-01-19  John Baldwin  <jhb@FreeBSD.org>
>>>  
>>> +	* fbsd-tdep.c (fbsd_pid_to_exec_file): Use new "buflen" instead of
>>> +	"len" with sysctl.
>>
>> ... should be "fbsd-nat.c".
> 
> Err, yes.  I also noticed after mailing that the 'len' variable is now
> initialized unnecessarily (since it's value is always overwritten by the
> call to readlink() after the #endif).  Is it ok to push this modified
> version:

Yes, of course.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]