This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH v4 4/7] Display per-thread information for threads in FreeBSD cores.


This is OK.

On 01/18/2016 06:37 PM, John Baldwin wrote:

> +	      /* Note that each thread will report the process command
> +		 as its thread name instead of an empty name if a name
> +		 has not been set explicitly.  Return a NULL name in
> +		 that case.  */
> +	      if (strcmp (buf, elf_tdata (core_bfd)->core->program) != 0)
> +		  return buf;

(Not sure, but I think the alignment of that return is odd.)

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]