Re: [PATCH] sim: allow the inline configure option everywhere [committed]

[Steve Ellcey <sellcey at imgtec dot com>]

On Tue, 2016-01-12 at 17:17 -0500, Mike Frysinger wrote:
> On 12 Jan 2016 13:47, Steve Ellcey wrote:
> > On Sun, 2016-01-10 at 03:40 -0500, Mike Frysinger wrote:
> > > Currently ports have to call SIM_AC_OPTION_INLINE explicitly in order
> > > to make the configure flag available.  There's no real reason to not
> > > allow this flag for all ports, so move it to the common sim macro.
> > > This way we get standard behavior across all ports too.
> > 
> > Before this patch was checked in (commit
> > 347fe5bb868b7383d4f6942894b31ecf1da6894e), when I built all-gdb for the
> > target mips-mti-linux-gnu, sim was not built.  After the change, it does
> > get built
> 
> i'm fairly certain that is not the case.  that commit did not change the
> top level or the common sim configure at all, and the mips-specific change
> did not impact whether it was built.

OK, I see what was happening.  I didn't think sim was getting built
because I wasn't building all-sim and install-sim and so there was no
mips-mti-linux-gnu-run in the install directory but the component was
still getting built as part of gdb.

> > (well, it tries to get built, it actually fails to build).
> 
> that is a bug in the sim introduced by commit 8e394ffc7ab691eafcf276d7ae.
> i filed a bug for it here:
> https://sourceware.org/bugzilla/show_bug.cgi?id=19441

OK, with the old inline setting I wasn't seeing this and now I am, that
makes sense now.  I'll ping Andrew about the bug and see about fixing
it.

Steve Ellcey
sellcey@imgtec.com