Re: [PATCH v2] Per-inferior/Inferior-qualified thread IDs

[Pedro Alves <palves at redhat dot com>]

On 01/05/2016 10:01 AM, Yao Qi wrote:
> Pedro Alves <palves@redhat.com> writes:
> 
> Hi, Pedro,
> It is a good direction to go

Great!

> but can we make this patch into smaller pieces?

Yes, I'll split into pieces and resend.

>> -/* *PP is a string denoting a number.  Get the number of the.  Advance
>> -   *PP after the string and any trailing whitespace.
>> +/* *PP is a string denoting a number.  Get the number.  Advance PP
>> +   *after the string and any trailing whitespace.
> 
> Should be "*PP".

Fixed.

> 
>> +
>> +# Remove the second inferior and confirm that GDB goes back to showing
>> +# single-number thread IDs.
>> +with_test_prefix "back to one inferior" {
>> +    gdb_test "kill inferior 2" "" "kill inferior 2" "Kill the program being debugged.*" "y"
>> +    gdb_test "thread 1.1" "Switching to thread 1\.1 .*"
>> +    gdb_test "remove-inferior 2" ".*" "remove inferior 2"
>> +
>> +    # "info threads" while there's only inferior 1 should show
>> +    # single-number thread IDs.
>> +    info_threads "" "1 2 3"
>> +
>> +    gdb_test "thread" "Current thread is 1 .*"
>> +}
>> +
>> +# Add another inferior and remove inferior 1.  Since even though
>> +# there's a single inferior, it's number is not 1, GDB should show
> 
> s/it's/its/
> 

Fixed.

Thanks,
Pedro Alves