This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix -Wno-unknown-warning support detection


On 12/16/2015 11:07 PM, Simon Marchi wrote:

> It looks good.  

I pushed it, thanks.

Note that you could have done
> 
>   wtest=`echo $w | sed 's/-Wno-/-W/g'`
> 
> unconditionally.  If it doesn't match, it won't replace anything:
> 
> $ echo -Wlol | sed 's/-Wno-/-W/g'
> -Wlol
> $ echo -Wno-lol | sed 's/-Wno-/-W/g'
> -Wlol

Yep, but I wrote it like that to avoid spawning external
processes unless necessary.  That adds up and slows configure down.

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]