This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] gdb.base/async.exp: Handle "asynchronous execution not supported"


On 12/08/2015 08:17 PM, Kevin Buettner wrote:
> On Tue, 8 Dec 2015 09:01:24 +0100
> Joel Brobecker <brobecker@adacore.com> wrote:
> 
>> You might want to escape the period you're trying to match
>> at the end of the sentence. Other than that, LGTM.
> 
> Fixed in new patch.  (See below.)
> 
> I've addressed Pedro's concerns too.
> 

Thanks, LGTM.

>> Looking at this, would it be possible in this case to replace
>> the send_gdb/gdb_expect into test_gdb_multiple? I'm not really
>> sure, because of the async nature makes ordering of the output
>> relative to the gdb_prompt different from usual, and thus perhaps
>> outside the scope of what test_gdb_multiple is capable of doing...
> 
> I don't know the answer to this either.  I'll defer to someone
> who knows more about this than I do.

I think I recall trying gdb_test_multiple for 884e37dc, but not sure.
The prompt matching within gdb_test_multiple will definitely be the
thing to watch out for.

> 
> Here's an updated patch...
> 

Thanks,
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]