This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- From: Ruslan Kabatsayev <b7 dot 10110111 at gmail dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 2 Dec 2015 17:26:19 +0300
- Subject: Re: [PATCH][PR 18702] Fix wrong output of x87 registers due to truncation to double on amd64
- Authentication-results: sourceware.org; auth=none
- References: <564F998D dot 5080406 at gmail dot com> <86mvttt7be dot fsf at gmail dot com>
Hi Yao,
Thanks for your reply.
On Wed, Dec 2, 2015 at 2:32 PM, Yao Qi <qiyaoltc@gmail.com> wrote:
> I think your patch is correct, but I am not confident approving it
> because I know few about floating point stuff. Do you run GDB
> regression tests?
I did a `make check` for unpatched gdb-7.10 and patched with my
changes. Here's the unpatched result:
# of expected passes 32377
# of unexpected failures 85
# of unexpected successes 2
# of expected failures 72
# of unknown successes 2
# of known failures 62
# of untested testcases 36
# of unsupported tests 201
And here's after my patch:
# of expected passes 32378
# of unexpected failures 85
# of unexpected successes 2
# of expected failures 71
# of unknown successes 2
# of known failures 62
# of untested testcases 36
# of unsupported tests 201
I.e. one "expected failure" less and one "expected pass" more. I'm not
sure how to interpret this result.
>> gdb/ChangeLog:
>>
>> * configure.host: Fix detection of x86_64 host when setting floatformats
>
> This line is too long, the max is 74. Sentence should be ended with ".".
Should I resend the whole original mail with this fixed?
Regards,
Ruslan