This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Thu, 26 Nov 2015 12:37:57 +0000
- Subject: Re: [PATCH 5/7] gdb: 'list' command, tweak handling of +/- arguments.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1448411121 dot git dot andrew dot burgess at embecosm dot com> <0af61eb3baed9334e8dc0aae2b572d87e2807fa8 dot 1448411122 dot git dot andrew dot burgess at embecosm dot com>
On 11/25/2015 12:34 AM, Andrew Burgess wrote:
> gdb/ChangeLog:
>
> * cli/cli-cmds.c (list_command): Check that the argument string is
> a single character, either '+' or '-'.
>
> gdb/testsuite/ChangeLog:
>
> * gdb.base/list.exp (test_list_invalid_args): New function,
> defined, and called.
> + clean_restart ${binfile}
> + gdb_test "list -INVALID" \
> + "invalid explicit location argument, \"-INVALID\"" \
> + "First use of \"list -INVALID\""
> + gdb_test "list -INVALID" \
> + "invalid explicit location argument, \"-INVALID\"" \
> + "Second use of \"list -INVALID\""
Nit: please use lowercase in test messages like mostly
everywhere else (including this file).
OK with that fixed.
Thanks,
Pedro Alves