This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: off-trunk gdb.fortran/dwarf-stride.exp no longer PASSes [Re: [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Keven Boell <keven dot boell at intel dot com>, gdb-patches at sourceware dot org
- Date: Wed, 4 Nov 2015 13:48:15 -0800
- Subject: Re: off-trunk gdb.fortran/dwarf-stride.exp no longer PASSes [Re: [PATCH 0/2] fort_dyn_array: Enable basic Fortran dynamic array support]
- Authentication-results: sourceware.org; auth=none
- References: <1435754532-17922-1-git-send-email-keven dot boell at intel dot com> <20151027212831 dot GA3058 at host1 dot jankratochvil dot net> <20151027212954 dot GA19347 at host1 dot jankratochvil dot net> <20151028161907 dot GB4009 at adacore dot com> <20151029223619 dot GA12147 at host1 dot jankratochvil dot net>
> Apparently the VLA patchset is not yet checked-in completely, for example the
> off-trunk patchset formerly contained:
>
> attr = dwarf2_attr (die, DW_AT_string_length, cu);
> if (attr)
> {
> - length = DW_UNSND (attr);
> + if (attr_form_is_block (attr))
> + {
>
> but current FSF GDB HEAD does not yet recognize attr_form_is_block for
> DW_AT_string_length at all so it just cannot work yet.
>
> I will have to apply only remaining parts of the former off-trunk patchset but
> that is sure off-topic for upstream GDB.
Just to be sure - did we regress on something in the master branch?
Or is this just a regression on your branch when you only rely on
the changes that were made on master?
The changes that were first submitted early on in the process were
too big, and I suspect some of them were also OBE, so I asked that
the patches be submitted piecemeal, to allow me to understand why
each change was made. This allowed us to eventually get a good chunk
of the work in, but as you can see, some chunks appear to still be
missing...
--
Joel