This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH c++ 04/12] target_ops masK_watchpoint: change int to target_hw_bp_type
- From: Pedro Alves <palves at redhat dot com>
- To: Simon Marchi <simon dot marchi at ericsson dot com>, gdb-patches at sourceware dot org
- Cc: Simon Marchi <simon dot marchi at polymtl dot ca>
- Date: Tue, 03 Nov 2015 16:14:02 +0000
- Subject: Re: [PATCH c++ 04/12] target_ops masK_watchpoint: change int to target_hw_bp_type
- Authentication-results: sourceware.org; auth=none
- References: <1446560804-18858-1-git-send-email-simon dot marchi at ericsson dot com> <1446560804-18858-4-git-send-email-simon dot marchi at ericsson dot com>
On 11/03/2015 02:26 PM, Simon Marchi wrote:
> From: Simon Marchi <simon.marchi@polymtl.ca>
>
> Fixes:
>
> /home/simark/src/binutils-gdb/gdb/ppc-linux-nat.c: In function âint ppc_linux_insert_mask_watchpoint(target_ops*, CORE_ADDR, CORE_ADDR, int)â:
> /home/simark/src/binutils-gdb/gdb/ppc-linux-nat.c:1730:40: error: invalid conversion from âintâ to âtarget_hw_bp_typeâ [-fpermissive]
> p.trigger_type = get_trigger_type (rw);
> ^
>
> gdb/ChangeLog:
>
> * ppc-linux-nat.c (ppc_linux_insert_mask_watchpoint): Change
> type of rw to enum target_hw_bp_type.
> (ppc_linux_remove_mask_watchpoint): Likewise.
> * target.c (target_insert_mask_watchpoint): Likewise.
> (target_remove_mask_watchpoint): Likewise.
> * target.h (target_insert_mask_watchpoint): Likewise.
> (target_remove_mask_watchpoint): Likewise.
> (struct target_ops) <to_insert_mask_watchpoint>: Likewise.
> (struct target_ops) <to_remove_mask_watchpoint>: Likewise.
> * target-delegates.c: Regenerate.
OK. (nit: typo in subject)
Thanks,
Pedro Alves