This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[PATCH obv/c++] Add/adjust casts in gdbserver's proc-service


FYI, I just pushed this as obvious.

The casts are required because ps_pd{read,write}Âmust respect a fixed
interface.

gdb/gdbserver/ChangeLog:

	* proc-service.c (ps_pdread): Add/adjust casts.
	(ps_pdwrite): Add/adjust casts.
---
 gdb/gdbserver/ChangeLog      | 5 +++++
 gdb/gdbserver/proc-service.c | 5 +++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog
index 4397ff9..70d832f 100644
--- a/gdb/gdbserver/ChangeLog
+++ b/gdb/gdbserver/ChangeLog
@@ -1,3 +1,8 @@
+2015-10-29  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* proc-service.c (ps_pdread): Add/adjust casts.
+	(ps_pdwrite): Add/adjust casts.
+
 2015-10-29  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	* server.c (handle_search_memory_1): Cast return value of
diff --git a/gdb/gdbserver/proc-service.c b/gdb/gdbserver/proc-service.c
index 128939d..ae00086 100644
--- a/gdb/gdbserver/proc-service.c
+++ b/gdb/gdbserver/proc-service.c
@@ -80,7 +80,7 @@ ps_err_e
 ps_pdread (gdb_ps_prochandle_t ph, psaddr_t addr,
 	   gdb_ps_read_buf_t buf, gdb_ps_size_t size)
 {
-  read_inferior_memory ((unsigned long) addr, buf, size);
+  read_inferior_memory ((CORE_ADDR) addr, (gdb_byte *) buf, size);
   return PS_OK;
 }
 
@@ -90,7 +90,8 @@ ps_err_e
 ps_pdwrite (gdb_ps_prochandle_t ph, psaddr_t addr,
 	    gdb_ps_write_buf_t buf, gdb_ps_size_t size)
 {
-  if (write_inferior_memory ((unsigned long) addr, buf, size) != 0)
+  if (write_inferior_memory ((CORE_ADDR) addr, (const gdb_byte *) buf, size)
+      != 0)
     return PS_ERR;
   return PS_OK;
 }
-- 
2.5.1


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]