RE: [PATCH 4/7] gdbserver: btrace enums

["Metzger, Markus T" <markus dot t dot metzger at intel dot com>]

> -----Original Message-----
> From: gdb-patches-owner@sourceware.org [mailto:gdb-patches-
> owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, October 28, 2015 3:59 PM
> To: gdb-patches@sourceware.org
> Subject: [PATCH 4/7] gdbserver: btrace enums

Hello Pedro,

>  ../../../src/gdb/gdbserver/linux-low.c: In function âint
> linux_low_read_btrace(btrace_target_info*, buffer*, int)â:
>  ../../../src/gdb/gdbserver/linux-low.c:6827:48: error: invalid conversion from
> âintâ to âbtrace_read_typeâ [-fpermissive]
>     err = linux_read_btrace (&btrace, tinfo, type);
> 						 ^
>  In file included from ../../../src/gdb/gdbserver/linux-low.c:98:0:
>  ../../../src/gdb/gdbserver/../nat/linux-btrace.h:116:26: error:   initializing
> argument 3 of âbtrace_error linux_read_btrace(btrace_data*,
> btrace_target_info*, btrace_read_type)â [-fpermissive]
>   extern enum btrace_error linux_read_btrace (struct btrace_data *btrace,
> 			   ^
> 
> I didn't spot the cyclic dependency the comment talks about.

At that time, you had to include server.h/defs.h before vec.h.  So I couldn't
include btrace-common.h (which includes vec.h and also server.h) into target.h,
which was in turn included in server.h.


The patch looks good to me.

Thanks,
Markus.

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928