This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Fix access_to_packed_array.exp typos/errors [Re: [PATCH] [Ada] Fix the evaluation of access to packed array subscript]
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: Pierre-Marie de Rodat <derodat at adacore dot com>, gdb-patches at sourceware dot org
- Date: Mon, 26 Oct 2015 15:05:19 -0700
- Subject: Re: [patch] Fix access_to_packed_array.exp typos/errors [Re: [PATCH] [Ada] Fix the evaluation of access to packed array subscript]
- Authentication-results: sourceware.org; auth=none
- References: <1442237665-9848-1-git-send-email-derodat at adacore dot com> <20150914141800 dot GA10154 at adacore dot com> <20151025110818 dot GA25554 at host1 dot jankratochvil dot net>
> On Mon, 14 Sep 2015 16:18:00 +0200, Joel Brobecker wrote:
> > > * gdb.ada/access_to_packed_array.exp: New testcase.
> >
> > Looks good to me. Please go ahead and push.
>
> Running ./gdb.ada/access_to_packed_array.exp ...
> ERROR: tcl error sourcing ./gdb.ada/access_to_packed_array.exp.
> ERROR: extra characters after close-quote
> while executing
> "gdb_test "print pack.a" "\\(0 => 1, 2, 3, 4, 5, 6, 7, 8, 9, 10\\)")"
> (file "./gdb.ada/access_to_packed_array.exp" line 29)
> invoked from within
> "source ./gdb.ada/access_to_packed_array.exp"
> ("uplevel" body line 1)
> invoked from within
> "uplevel #0 source ./gdb.ada/access_to_packed_array.exp"
> invoked from within
> "catch "uplevel #0 source $test_file_name""
>
> Attaching a fix of the typos.
Embarrassing... PM must have sent for review a version of the script
that's different from the version he tested, and I failed to catch
this.
> Unrelated to the typos I have changed the print expectations s/"x"/" = x"/
> as for example expectation "3" should not match " = 43".
Another good improvement indeeed.
> On Fedora 21 x86_64 it then:
> # of expected passes 5
>
> OK for check-in?
>
>
> Jan
> gdb/testsuite/ChangeLog
> 2015-10-25 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> * gdb.ada/access_to_packed_array.exp: Fix typos erroring the testfile.
Yes, please. And thank you for fixing!
--
Joel