This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch, testsuite] adjust timeout in gdb.base/freebpcmd.exp
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Wed, 21 Oct 2015 10:12:11 -0600
- Subject: [patch, testsuite] adjust timeout in gdb.base/freebpcmd.exp
- Authentication-results: sourceware.org; auth=none
I've been observing random failures in gdb.base/freebpcmd.exp on a
bare-metal target using RSP with a slow debug probe. It seems that the
hardwired timeout of 120 seconds for this test is just a little too low
for this target. It seems better to use with_timeout_factor instead of
a hardwired value; choosing a factor of 10 here is totally random, but
it seems to be plenty on this target (its default timeout is 60).
OK to commit?
-Sandra
2015-10-21 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.base/freebpcmd.exp: Use with_timeout_factor instead
of hardwired timeout value.
diff --git a/gdb/testsuite/gdb.base/freebpcmd.exp b/gdb/testsuite/gdb.base/freebpcmd.exp
index 2f46bc8..c7c0814 100644
--- a/gdb/testsuite/gdb.base/freebpcmd.exp
+++ b/gdb/testsuite/gdb.base/freebpcmd.exp
@@ -103,22 +103,19 @@ if {$i >= [llength $lines]} {
gdb_run_cmd
-set prev_timeout $timeout
-set timeout 120
-
-gdb_test_multiple "" "run program with breakpoint commands" {
- -re "warning: Invalid control type in command structure" {
- kfail "gdb/1489" "run program with breakpoint commands"
- }
- -re "Invalid i value\r\n$gdb_prompt $" {
- xfail "run program with breakpoint commands (i value not readable)"
- }
- -re "$gdb_prompt $" {
- pass "run program with breakpoint commands"
- }
- eof {
- kfail "gdb/1489" "run program with breakpoint commands (GDB died)"
+with_timeout_factor 10 {
+ gdb_test_multiple "" "run program with breakpoint commands" {
+ -re "warning: Invalid control type in command structure" {
+ kfail "gdb/1489" "run program with breakpoint commands"
+ }
+ -re "Invalid i value\r\n$gdb_prompt $" {
+ xfail "run program with breakpoint commands (i value not readable)"
+ }
+ -re "$gdb_prompt $" {
+ pass "run program with breakpoint commands"
+ }
+ eof {
+ kfail "gdb/1489" "run program with breakpoint commands (GDB died)"
+ }
}
}
-
-set timeout $prev_timeout