This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports
- From: Pedro Alves <palves at redhat dot com>
- To: Iain Buclaw <ibuclaw at gdcproject dot org>, GDB Patches <gdb-patches at sourceware dot org>
- Date: Mon, 19 Oct 2015 16:42:07 +0100
- Subject: Re: [PATCH 2/2] [D] Remove search_parents parameter from d_lookup_symbol_imports
- Authentication-results: sourceware.org; auth=none
- References: <CABOHX+dAvESSm0gHL4vvwX4JuoZhiy+uac6hSirQ6c35Da0_SQ at mail dot gmail dot com>
On 10/11/2015 01:01 PM, Iain Buclaw wrote:
> Whilst looking at part one, a moment of insight came to me and I
> realized this code is completely nonsensical.
>
> For a start, when importing modules, you don't gain access to all
> parent packages of the given module.
>
> To add some confusion, even the comment was wrong. It doesn't even
> cater for the example given (it's d_lookup_symbol_module that walks up
> each block scope).
>
> I feel embarrassed it didn't come to me before. :-)
The usual penance is writing test cases. :-)
Thanks,
Pedro Alves