This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: dje at google dot com, gdb-patches at sourceware dot org, palves at redhat dot com
- Date: Mon, 19 Oct 2015 12:37:27 +0300
- Subject: Re: [PATCH v2 4/4] btrace: add instruction-history /s and fix documentation
- Authentication-results: sourceware.org; auth=none
- References: <1445246610-11645-1-git-send-email-markus dot t dot metzger at intel dot com> <1445246610-11645-5-git-send-email-markus dot t dot metzger at intel dot com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, palves@redhat.com
> Date: Mon, 19 Oct 2015 11:23:30 +0200
>
> +It can also print mixed source+disassembly by specifying the @code{/m}
> +or @code{/s} modifier and print the raw instructions in hex as well as
> +in symbolic form by specifying the @code{/r} modifier.
"By specifying" makes it sound like you are talking about the command,
because of the "It" that starts the sentence. Suggest to reword:
It can also print mixed source+disassembly if you specify the @code{/m}
or @code{/s} modifier, and print the raw instructions in hex as well as
in symbolic form by specifying the @code{/r} modifier.
Note that I also added a missing comma before "and".
The documentation parts are okay with this fixed.
Thanks.