This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2 1/7] Add breakpoint_from_pc target_ops for software breakpoints in GDBServer.
- From: Pedro Alves <palves at redhat dot com>
- To: Antoine Tremblay <antoine dot tremblay at ericsson dot com>, gdb-patches at sourceware dot org
- Date: Thu, 15 Oct 2015 16:33:44 +0100
- Subject: Re: [PATCH v2 1/7] Add breakpoint_from_pc target_ops for software breakpoints in GDBServer.
- Authentication-results: sourceware.org; auth=none
- References: <1444063455-31558-1-git-send-email-antoine dot tremblay at ericsson dot com> <1444063455-31558-2-git-send-email-antoine dot tremblay at ericsson dot com>
On 10/05/2015 05:44 PM, Antoine Tremblay wrote:
> +static const unsigned char *
gdb_byte?
> +aarch64_breakpoint_from_pc (CORE_ADDR *pcptr, int *len)
> +{
> + *len = aarch64_breakpoint_len;
> + return (const unsigned char *) &aarch64_breakpoint;
... and then this cast goes away.
> +}
> +
> +static const unsigned char *
> +arm_breakpoint_from_pc (CORE_ADDR *pcptr, int *len)
> +{
Missing '/* Implementation of ... */' comment.
> +}
> struct linux_target_ops the_low_target = {
Missing empty line.
> +
> + /* Return the raw breakpoint for this target based on PC. The PCPTR is
> + ajusted to the real memory location in case a flag was present in the
"adjusted". Suggest an example, like "a flag (e.g., the Thumb bit on ARM) was"
> + PC. */
> + const unsigned char *(*breakpoint_from_pc) (CORE_ADDR *pcptr, int *lenptr);
Thanks,
Pedro Alves