This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'.
- From: Pedro Alves <palves at redhat dot com>
- To: Andrew Burgess <andrew dot burgess at embecosm dot com>, gdb-patches at sourceware dot org
- Date: Wed, 30 Sep 2015 15:00:32 +0100
- Subject: Re: [PATCH 9/9] gdb: Change how frames are selected for 'frame' and 'info frame'.
- Authentication-results: sourceware.org; auth=none
- References: <cover dot 1441996064 dot git dot andrew dot burgess at embecosm dot com> <2d36cf742ecb05db45a18f5025f42ad58d780fa8 dot 1441996064 dot git dot andrew dot burgess at embecosm dot com>
On 09/11/2015 07:49 PM, Andrew Burgess wrote:
> --- a/gdb/stack.c
> +++ b/gdb/stack.c
> @@ -100,6 +100,9 @@ static void set_last_displayed_sal (int valid,
> struct symtab *symtab,
> int line);
> +static struct frame_info * find_frame_for_function (char *);
> +static struct frame_info * find_frame_for_address (CORE_ADDR);
No space after first *. Also, can that be "const char *" ?
But most importantly - is there a reason this is implemented
the way it is (manually handling completion, parsing, etc.) instead of
creating sub-commands for "frame", etc., like done e.g., for "thread",
thread apply", "thread apply all", etc. ?