This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH, FT32] Proper support for address <-> pointer conversions
- From: Doug Evans <dje at google dot com>
- To: James Bowman <james dot bowman at ftdichip dot com>
- Cc: Yao Qi <qiyaoltc at gmail dot com>, "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Tue, 22 Sep 2015 12:53:31 -0700
- Subject: Re: [PATCH, FT32] Proper support for address <-> pointer conversions
- Authentication-results: sourceware.org; auth=none
- References: <CA9BBF0458F83C4F9051448B941B57D119614F72 at glaexch1> <86wpvi9zst dot fsf at gmail dot com> <CA9BBF0458F83C4F9051448B941B57D119614FCF at glaexch1>
On Tue, Sep 22, 2015 at 11:37 AM, James Bowman
> Thanks for the review. Corrected Changelog/patch is below.
> However I was not sure about splitting -- these changes all
> seem to go together. That is, applying just some of the patch
> results in a non-functioning gdb.
> 2015-09-22 James Bowman <email@example.com>
> * ft32-tdep.c: Implement the pointer to address method so
> that FT32's address spaces (RAM and flash) work correctly when
> dereferencing pointers in gdb. Also make PC a flash pointer.
> * ft32-tdep.h: Add a type for an address space 1 pointer, for
> the PC.
Yeah, there'll always be some grey area as to when one should split up a patch.
This patch is small enough and is completely target specific.
The ChangeLog is still incorrect though. E.g. compare with just about
every existing changelog entry.
gdb's pretty good at following its own conventions, and that in turn
makes it easy to continue to follow them.
Just go with the flow and mimic (without being creative) what's already there.