This is the mail archive of the
mailing list for the GDB project.
[PATCH 0/6] disasm, record: fix "record instruction-history /m"
- From: Markus Metzger <markus dot t dot metzger at intel dot com>
- To: palves at redhat dot com, dje at google dot com
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 21 Sep 2015 16:54:37 +0200
- Subject: [PATCH 0/6] disasm, record: fix "record instruction-history /m"
- Authentication-results: sourceware.org; auth=none
The /m modifier interleaves source lines with the disassembly of recorded
instructions. This calls disasm.c's do_mixed_source_and_assembly once for
each recorded instruction to be printed.
The latter really does a source print with intermixed disassembly. To that
purpose, it may reorder instructions to better match the source. This doesn't
work for printing a single instruction.
The new DISASSEMBLY_SOURCE mode promises to improve that as it preserves the
order of instructions. It still assumes a consecutive range of instructions
in some places.
Extend it so it can be used for source interleaving in the "record
There is an open regarding MI output of "record instruction-history". The
current version seems pretty broken as it will put each instruction into its
own "asm_insns" list. This isn't that bad since there is no real MI support
for record btrace, yet.
This new version puts all instructions into the same list - unless there are
gaps in the trace. For gaps, we will end up with one list per consecutive trace
segment plus the error message for the gaps.
To get this also into a single "asm_insns" list, we'd need to further extend
struct disas_insn to support gaps instead of instructions. I have not done
this as I first wanted to see if the current changes are not already too
See also branch users/mmetzger/disasm-vec.
I tested this series on 64-bit IA running RHEL 7.
Markus Metzger (6):
disasm: change dump_insns to print a single instruction
disasm: add struct disas_insn to describe to-be-disassembled
disas: add gdb_disassembly_vec
disasm: use entire line table in line_has_code_p
disasm: determine preceding lines independent of last_line
btrace: use gdb_disassembly_vec and new source interleaving method
gdb/disasm.c | 549 +++++++++++++++++++++++++++-------------------------
gdb/disasm.h | 24 +++
gdb/record-btrace.c | 54 +++---
gdb/record.c | 2 +-
4 files changed, 341 insertions(+), 288 deletions(-)