This is the mail archive of the
mailing list for the GDB project.
[COMMITTED PATCH] dwarf2_compute_name: add fixme, don't use same name as parameter for local
- From: Doug Evans <xdje42 at gmail dot com>
- To: gdb-patches at sourceware dot org
- Date: Sun, 20 Sep 2015 14:20:37 -0700
- Subject: [COMMITTED PATCH] dwarf2_compute_name: add fixme, don't use same name as parameter for local
- Authentication-results: sourceware.org; auth=none
I've committed this.
Later I intend to remove the FIXME but right now it helps keep my mind
straight since I can only get to this sporadically.
Regression tested on amd64-linux.
2015-09-20 Doug Evans <email@example.com>
* dwarf2read.c (dwarf2_compute_name): Add FIXME. Don't use a local
variable name that collides with a parameter.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 6ec8595..b8c0872 100644
@@ -8431,8 +8431,13 @@ dwarf2_compute_name (const char *name,
if (name == NULL)
name = dwarf2_name (die, cu);
- /* For Fortran GDB prefers DW_AT_*linkage_name if present but otherwise
- compute it by typename_concat inside GDB. */
+ /* For Fortran GDB prefers DW_AT_*linkage_name for the physname if present
+ but otherwise compute it by typename_concat inside GDB.
+ FIXME: Actually this is not really true, or at least not always true.
+ It's all very confusing. SYMBOL_SET_NAMES doesn't try to demangle
+ Fortran names because there is no mangling standard. So new_symbol_full
+ will set the demangled name to the result of dwarf2_full_name, and it is
+ the demangled name that GDB uses if it exists. */
if (cu->language == language_ada
|| (cu->language == language_fortran && physname))
@@ -8441,13 +8446,13 @@ dwarf2_compute_name (const char *name,
to be able to reference. Ideally, we want the user to be able
to reference this entity using either natural or linkage name,
but we haven't started looking at this enhancement yet. */
- const char *name;
+ const char *linkage_name;
- name = dwarf2_string_attr (die, DW_AT_linkage_name, cu);
- if (name == NULL)
- name = dwarf2_string_attr (die, DW_AT_MIPS_linkage_name, cu);
- if (name != NULL)
- return name;
+ linkage_name = dwarf2_string_attr (die, DW_AT_linkage_name, cu);
+ if (linkage_name == NULL)
+ linkage_name = dwarf2_string_attr (die, DW_AT_MIPS_linkage_name, cu);
+ if (linkage_name != NULL)
+ return linkage_name;
/* These are the only languages we know how to qualify names in. */