This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[patch, testsuite] fix problems in gdb.base/paginate-bg-execution.exp
- From: Sandra Loosemore <sandra at codesourcery dot com>
- To: gdb-patches <gdb-patches at sourceware dot org>
- Date: Fri, 18 Sep 2015 13:52:38 -0600
- Subject: [patch, testsuite] fix problems in gdb.base/paginate-bg-execution.exp
- Authentication-results: sourceware.org; auth=none
This patch addresses a couple of problems in
gdb.base/paginate-bg-execution.exp:
(1) A different "Quit" message can appear in some cases, e.g. if GDB
thinks the terminal doesn't support job control -- see the definition of
quit in utils.c. The specific situation where I tripped over this was
running GDB in a CMD.EXE shell on a remote Windows host via ssh -T.
(2) The test was sending a ^C interrupt without testing whether the
target had the nointerrupts property set.
OK to commit? (I'm not sure this one qualifies as obvious.)
-Sandra
2015-09-18 Sandra Loosemore <sandra@codesourcery.com>
gdb/testsuite/
* gdb.base/paginate-bg-execution.exp: Accept alternate "Quit"
message. Skip ^C test if target has nointerrupts set.
diff --git a/gdb/testsuite/gdb.base/paginate-bg-execution.exp b/gdb/testsuite/gdb.base/paginate-bg-execution.exp
index f7437ac..7b96df7 100644
--- a/gdb/testsuite/gdb.base/paginate-bg-execution.exp
+++ b/gdb/testsuite/gdb.base/paginate-bg-execution.exp
@@ -104,6 +104,11 @@ proc test_bg_execution_pagination_cancel { how } {
-re "Quit\r\n$gdb_prompt $" {
pass $test
}
+ # This variant can show up e.g. in remote testing via ssh -T,
+ # so that GDB has no terminal.
+ -re "Quit (expect signal SIGINT when the program is resumed)\r\n$gdb_prompt $" {
+ pass $test
+ }
}
gdb_test "p 1" " = 1" "GDB accepts further input"
@@ -114,5 +119,7 @@ proc test_bg_execution_pagination_cancel { how } {
}
test_bg_execution_pagination_return
-test_bg_execution_pagination_cancel "ctrl-c"
+if ![target_info exists gdb,nointerrupts] {
+ test_bg_execution_pagination_cancel "ctrl-c"
+}
test_bg_execution_pagination_cancel "quit"