This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3 19/19] btrace: honour scheduler-locking for all-stop targets
- From: Pedro Alves <palves at redhat dot com>
- To: Markus Metzger <markus dot t dot metzger at intel dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 18 Sep 2015 12:39:48 +0100
- Subject: Re: [PATCH v3 19/19] btrace: honour scheduler-locking for all-stop targets
- Authentication-results: sourceware.org; auth=none
- References: <1442498990-1222-1-git-send-email-markus dot t dot metzger at intel dot com> <1442498990-1222-20-git-send-email-markus dot t dot metzger at intel dot com>
On 09/17/2015 03:09 PM, Markus Metzger wrote:
> +foreach schedlock { "replay" "on" } {
> + with_test_prefix "schedlock-$schedlock" {
> + gdb_test_no_output "set scheduler-locking $schedlock"
> +
> + test_navigate
> + test_step
> + test_cont
> + test_rstep
> + test_goto_end
> + }
> }
>
Indenting here looks odd compared to the rest of the file.
I'd merge in the "step" case too, like:
foreach schedlock { "replay" "on" "step" } {
with_test_prefix "schedlock-$schedlock" {
gdb_test_no_output "set scheduler-locking $schedlock"
test_navigate
test_step
if {$schedlock == "step"} {
test_cont_all
} else {
test_cont
}
test_rstep
test_goto_end
}
}
Otherwise looks fine to me.
Thanks,
Pedro Alves