This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ppc64le patch v3] Use skip_entrypoint for skip_trampoline_code

On Tue, 15 Sep 2015 18:39:17 +0200, Ulrich Weigand wrote:
> This is OK.

Thanks for the ppc64le arch review but I am not sure if it is also approval of
the coding style which I asked about (not specifically you) by:

On Mon, 07 Sep 2015 22:47:20 +0200, Jan Kratochvil wrote:
# Currently gdbarch_skip_entrypoint() has been called in skip_prologue_sal() and
# fill_in_stop_func() but that is not enough.  I believe
# gdbarch_skip_entrypoint() should be called after every
# gdbarch_skip_trampoline_code(), shouldn't it?
# The attached patch is a bit hack but I am not sure what is a clean solution.
# Maybe create a gdbarch_skip_trampoline_code() wrapper function calling also
# gdbarch_skip_entrypoint() and forbid calling gdbarch_skip_trampoline_code()
# directly?

I did not want to refactor it before asking as there are too many
possibilities how to do it and I expect I would not guess the right one.

OTOH the refactorization can be also considered a future task, if you mean it
that way.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]