This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH 17/17] infrun: scheduler-locking reverse

> -----Original Message-----
> From: Jan Kratochvil []
> Sent: Saturday, September 12, 2015 9:44 PM
> To: Pedro Alves
> Cc: Metzger, Markus T;
> Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse

Hello Jan,

> Thanks for bringing it up.  I would have hard time mergin this patch's:
> -static const char *scheduler_mode = schedlock_off;
> +static const char *scheduler_mode = schedlock_reverse;
> with
> step-is-default.patch
> -static const char *scheduler_mode = schedlock_off;
> +static const char *scheduler_mode = schedlock_step;

I don't believe that we need to preserve the current behaviour.  If Fedora
defaults to schedlock_step, why not also for record targets?

It could be seen as bug-fix that record targets did not honour scheduler-locking.

The same holds for mainline, of course.  But the new mode is much closer to
schedlock_step than it is to schedlock_off.

> My guess is there could be a new setting "set reverse-scheduler-locking" also
> with "off/step/on" as it seems to me "step" also makes sense for the
> scheduler
> locking in reverse mode.

This would allow us to set different scheduler-locking modes for reverse/replay
execution and for normal debugging.  While this adds flexibility, I'm not sure it is
actually needed.

I really only added the new mode because I did not want to change the default
behaviour completely.  Over time, I think we may want to deprecate it, even
though schedlock_off isn't very useful with the usually quite short execution
history.  Maybe mainline will default to schedlock_step one day, as well?


Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0,
Managing Directors: Christin Eisenschmid, Prof. Dr. Hermann Eul
Chairperson of the Supervisory Board: Tiffany Doon Silva
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]