This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 17/17] infrun: scheduler-locking reverse
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pedro Alves <palves at redhat dot com>
- Cc: Markus Metzger <markus dot t dot metzger at intel dot com>, gdb-patches at sourceware dot org
- Date: Sat, 12 Sep 2015 21:43:44 +0200
- Subject: Re: [PATCH 17/17] infrun: scheduler-locking reverse
- Authentication-results: sourceware.org; auth=none
- References: <1441794909-32718-1-git-send-email-markus dot t dot metzger at intel dot com> <1441794909-32718-18-git-send-email-markus dot t dot metzger at intel dot com> <55F03A12 dot 80307 at redhat dot com>
On Wed, 09 Sep 2015 15:54:26 +0200, Pedro Alves wrote:
> On 09/09/2015 11:35 AM, Markus Metzger wrote:
> > Record targets behave as if scheduler-locking were on during replay/reverse
> > execution. Add a new scheduler-locking option "reverse" to make this implicit
> > behaviour explicit. It behaves like "on" during reverse/replay execution and
> > like "off" during normal execution.
> >
> > By making the current behaviour a scheduler-locking option, we allow the user
> > to change it. Since it is the current behaviour, this new option is also
> > the new default.
>
> Hmm. The code looks fine. But I should point out that if a user
> has "schedlock step" in their gdbinit, they'll miss this. Fedora's gdb
> actually currently defaults to schedlock=step.
Thanks for bringing it up. I would have hard time mergin this patch's:
-static const char *scheduler_mode = schedlock_off;
+static const char *scheduler_mode = schedlock_reverse;
with
http://pkgs.fedoraproject.org/cgit/gdb.git/tree/gdb-6.6-scheduler_locking-step-is-default.patch
-static const char *scheduler_mode = schedlock_off;
+static const char *scheduler_mode = schedlock_step;
My guess is there could be a new setting "set reverse-scheduler-locking" also
with "off/step/on" as it seems to me "step" also makes sense for the scheduler
locking in reverse mode.
Or better "set reverse-scheduler-locking" with "off/on" where "on" would
behave for reverse mode as "step" if "set scheduler-locking" is set to "step".
I do not mind which way but I do not find the current user interface great.
Thanks,
Jan