This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] btrace, test: remove buffer-size test with unlimited buffer size
- From: Pedro Alves <palves at redhat dot com>
- To: "Metzger, Markus T" <markus dot t dot metzger at intel dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Fri, 11 Sep 2015 10:30:18 +0100
- Subject: Re: [PATCH] btrace, test: remove buffer-size test with unlimited buffer size
- Authentication-results: sourceware.org; auth=none
- References: <1441962171-20975-1-git-send-email-markus dot t dot metzger at intel dot com> <55F29BAB dot 8020808 at redhat dot com> <A78C989F6D9628469189715575E55B23331AD33B at IRSMSX104 dot ger dot corp dot intel dot com>
On 09/11/2015 10:18 AM, Metzger, Markus T wrote:
>> -----Original Message-----
>> From: Pedro Alves [mailto:email@example.com]
>> Sent: Friday, September 11, 2015 11:15 AM
>> To: Metzger, Markus T
>> Cc: firstname.lastname@example.org
>> Subject: Re: [PATCH] btrace, test: remove buffer-size test with unlimited
>> buffer size
>> On 09/11/2015 10:02 AM, Markus Metzger wrote:
>>> The gdb.btrace/buffer-size.exp test starts recording with an unlimited
>>> buffer size. This will, for a short time, use up most if not all BTS
>>> I don' think this test is necessary. Remove it.
>> Fine with me.
>> Note you don't really need approval to push this in.
> Nice. But we still want patches to be reviewed, don't we?
Certainly. And I'll gladly review anything you send my way.
> Or does this fall under the obvious rule?
I wouldn't say the idea is obvious, though once the idea
is accepted, the code changes are indeed obvious.