This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step
- From: Antoine Tremblay <antoine dot tremblay at ericsson dot com>
- To: Yao Qi <qiyaoltc at gmail dot com>, <gdb-patches at sourceware dot org>
- Date: Wed, 9 Sep 2015 11:37:52 -0400
- Subject: Re: [PATCH 1/2] [gdbserver] Rename supports_conditional_breakpoints to supports_hardware_single_step
- Authentication-results: sourceware.org; auth=none
- References: <1441096915-23615-1-git-send-email-yao dot qi at linaro dot org> <1441096915-23615-2-git-send-email-yao dot qi at linaro dot org>
- /* Although lynx has hardware single step, still disable this
- feature for lynx, because it is implemented in linux-low.c instead
- of in generic code. */
- NULL, /* supports_conditional_breakpoints */
NULL, /* stopped_by_watchpoint */
NULL, /* stopped_data_address */
NULL, /* read_offsets */
+/* Target can do hardware single step. */
+ return 1;
Why would we enable conditional breakpoints on lynx,win32 etc.. since I
think it's still valid that it's implemented in linux-low ?
Should we not default to return 0 in target_can_do_hardware_single_step ?