This is the mail archive of the mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] [Ada] Fix completion for multiple function matches

> I adjusted the testcase in the way I think you meant: I added the
> Ambiguous_Prog procedure to Aux_Pck and added a test to ask the completion
> of "p ambig": GDB correctly reports two possible completions: "p
> ambiguous_func" and "p ambiguous_proc". This looks independent of function
> resolution in ada-lang, and that is fortunate in our case. :-)
> Is this what you had in mind?

Yep :)

> gdb/ChangeLog:
> 	* ada-lang.c (ada_resolve_function): Do not ask the user what
> 	match to use when in completion mode.
> gdb/testsuite/ChangeLog:
> 	* gdb.ada/complete.exp: Add "pck.ambiguous_func" to the relevant
> 	expected outputs.  Add two testcases for completing ambiguous
> 	functions.
> 	* gdb.ada/complete/aux_pck.adb: New file.
> 	* gdb.ada/complete/ New file.
> 	* gdb.ada/complete/foo.adb: Pull Aux_Pck and call the two
> 	Ambiguous_Func functions.
> 	* gdb.ada/complete/ Add an Ambiguous_Func function.
> 	* gdb.ada/complete/pck.adb: Likewise.

Looks good. Go ahead and push :).

Thank you, Pierre-Marie.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]