This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH 2/2] Make remote file transfers interruptible
- From: Gary Benson <gbenson at redhat dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: gdb-patches at sourceware dot org, Doug Evans <dje at google dot com>, Pedro Alves <palves at redhat dot com>, Jan Kratochvil <jan dot kratochvil at redhat dot com>, André Pönitz <apoenitz at t-online dot de>, Paul_Koning at Dell dot com
- Date: Tue, 11 Aug 2015 11:52:21 +0100
- Subject: Re: [PATCH 2/2] Make remote file transfers interruptible
- Authentication-results: sourceware.org; auth=none
- References: <1438788496-32246-1-git-send-email-gbenson at redhat dot com> <1438788496-32246-3-git-send-email-gbenson at redhat dot com> <55C3A10F dot 3010106 at codesourcery dot com>
Hi Sandra,
Sandra Loosemore wrote:
> On 08/05/2015 09:28 AM, Gary Benson wrote:
> > This commit makes it possible to interrupt slow remote file transfers.
> >
> > gdb/ChangeLog:
> >
> > * gdb_bfd.c (gdb_bfd_iovec_fileio_pread): Add QUIT call.
>
> I think that this is the same patch that you sent earlier:
>
> https://sourceware.org/ml/gdb/2015-07/msg00043.html
>
> It still does not work for me. :-(
Ok, given the packet-size limit of RSP I was assuming GDB would read
the files in chunks the size of the server's packet buffer size (16k
for gdbserver) but it seems that that chunking happens at a lower
level, so the interrupt is only noticed between files rather than
between chunks. I tested this patch using "remote get", but it seems
that that operates differently. So I'm retracting this patch.
Making remote transfers properly interruptible looks like a fairly
involved task that's only slightly on my radar. I've filed a bug
(https://sourceware.org/bugzilla/show_bug.cgi?id=18804) to keep the
issue from being forgotten. I'll work on if I have some free time,
or someone else can do it.
The other patch in the series (the warning messages) can go in if
people find it useful.
Thanks,
Gary
--
http://gbenson.net/