This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On 08/01/2015 04:35 PM, Pierre-Marie de Rodat wrote:
On 08/01/2015 08:24 PM, Luis Machado wrote:Understood: here's an updated patch introducing a temporary to do this. Thank you!Thanks! I think you forgot to fix the other occurrences though.Arg, sorry: I thought you were suggesting this to get rid of the weird indentation behavior (hence my fix on the first occurence only). At this point I wonder what to do: this patch indeed introduces some of âfoo(..).barâ constructs, but my previous one introduced a _lot_ more. So my feeling is that the code will get bigger and less readable... that's my personal taste anyway. ;-) That being said, I'm completely open to settling on this style anyway, as long as we are aware of the consequences.
Indeed. I didn't review the original patch, so only this one caught my attention. I agree it is not worth fixing this if a bunch of other occurrences were added.
Maybe a new function should've been introduced to avoid having to keep accessing that field, which would be both shorter and cleaner.
Then again, it is probably only costmetic. The move to C++ will potentially introduce lots more occurrences in the future. :-)
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |