This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove isize output argument from fast_tracepoint_valid_at


Pierre Langlois <pierre.langlois@arm.com> writes:

> This patch removes the isize output argument from the
> fast_tracepoint_valid_at gdbarch hook.  It was used to return the size
> of the instruction that needs to be replaced when installing a fast
> tracepoint.  Instead of getting this value from the
> fast_tracepoint_valid_at hook, we can call the gdb_insn_length function.
>

If the argument of gdbarch hook interface is not necessary, let us
remove it.

>
> Regression tested with native-gdbserver on x86_64.

Could you please also test it on i686-linux?

> gdb/ChangeLog:
>
> 	* arch-utils.c (default_fast_tracepoint_valid_at): Remove unused
> 	isize argument.
> 	* arch-utils.h (default_fast_tracepoint_valid_at): Likewise.
> 	* breakpoint.c (check_fast_tracepoint_sals): Adjust call to
> 	gdbarch_fast_tracepoint_valid_at.
> 	* gdbarch.sh (fast_tracepoint_valid_at): Remove isize argument.
> 	* gdbarch.h: Regenerate.
> 	* gdbarch.c: Regenerate.
> 	* i386-tdep.c (i386_fast_tracepoint_valid_at): Remove isize
> 	argument.  Do not set it.
> 	* remote.c (remote_download_tracepoint): Adjust call to
> 	gdbarch_fast_tracepoint_valid_at.  Call gdb_insn_length to get
> 	the instruction length.

That patch looks good to me.  You can push it in if there is no
regression on i686-linux.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]